Bug 122705 - Remove unneeded extra memory allocation and indirection for ValidityState
Summary: Remove unneeded extra memory allocation and indirection for ValidityState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-12 16:49 PDT by Darin Adler
Modified: 2013-10-12 22:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (15.66 KB, patch)
2013-10-12 16:53 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (16.16 KB, patch)
2013-10-12 17:18 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-10-12 16:49:17 PDT 
Remove unneeded extra memory allocation and indirection for ValidityState
Comment 1 Darin Adler 2013-10-12 16:53:42 PDT 
Created attachment 214069 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-12 16:59:28 PDT 
Comment on attachment 214069 [details]
Patch

Attachment 214069 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3619092
Comment 3 EFL EWS Bot 2013-10-12 17:00:35 PDT 
Comment on attachment 214069 [details]
Patch

Attachment 214069 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3933083
Comment 4 Darin Adler 2013-10-12 17:18:08 PDT 
Created attachment 214072 [details]
Patch
Comment 5 Anders Carlsson 2013-10-12 21:30:37 PDT 
Comment on attachment 214072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214072&action=review

> Source/WebCore/html/ValidityState.h:41
> +    return static_cast<ValidityState*>(this);

This cast is really undefined behavior but it seems fine for now.
Comment 6 WebKit Commit Bot 2013-10-12 21:59:14 PDT 
Comment on attachment 214072 [details]
Patch

Clearing flags on attachment: 214072

Committed r157352: <http://trac.webkit.org/changeset/157352>
Comment 7 WebKit Commit Bot 2013-10-12 21:59:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2013-10-12 22:35:40 PDT 
Comment on attachment 214072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214072&action=review

>> Source/WebCore/html/ValidityState.h:41
>> +    return static_cast<ValidityState*>(this);
> 
> This cast is really undefined behavior but it seems fine for now.

Yup, I was trying to say that in the comments.