RESOLVED FIXED 122705
Remove unneeded extra memory allocation and indirection for ValidityState 
https://bugs.webkit.org/show_bug.cgi?id=122705
Summary Remove unneeded extra memory allocation and indirection for ValidityState
Darin Adler
Reported 2013-10-12 16:49:17 PDT
Remove unneeded extra memory allocation and indirection for ValidityState
Attachments
Patch (15.66 KB, patch)
2013-10-12 16:53 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (16.16 KB, patch)
2013-10-12 17:18 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-10-12 16:53:42 PDT
Created attachment 214069 [details] Patch
EFL EWS Bot
Comment 2 2013-10-12 16:59:28 PDT
Comment on attachment 214069 [details] Patch Attachment 214069 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3619092
EFL EWS Bot
Comment 3 2013-10-12 17:00:35 PDT
Comment on attachment 214069 [details] Patch Attachment 214069 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3933083
Darin Adler
Comment 4 2013-10-12 17:18:08 PDT
Created attachment 214072 [details] Patch
Anders Carlsson
Comment 5 2013-10-12 21:30:37 PDT
Comment on attachment 214072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214072&action=review > Source/WebCore/html/ValidityState.h:41 > + return static_cast<ValidityState*>(this); This cast is really undefined behavior but it seems fine for now.
WebKit Commit Bot
Comment 6 2013-10-12 21:59:14 PDT
Comment on attachment 214072 [details] Patch Clearing flags on attachment: 214072 Committed r157352: <http://trac.webkit.org/changeset/157352>
WebKit Commit Bot
Comment 7 2013-10-12 21:59:15 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 8 2013-10-12 22:35:40 PDT
Comment on attachment 214072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214072&action=review >> Source/WebCore/html/ValidityState.h:41 >> + return static_cast<ValidityState*>(this); > > This cast is really undefined behavior but it seems fine for now. Yup, I was trying to say that in the comments.
Note You need to log in before you can comment on or make changes to this bug.