Bug 122696 – Generate tighter isFooElement() functions for HTML elements.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Andreas Kling]

We shouldn't have to do a full QName compare for HTML elements.

[Andreas Kling]

Example:

class HTMLAnchorElement;
inline bool isHTMLAnchorElement(const HTMLElement& element) { return element.hasLocalName(HTMLNames::aTag); }
inline bool isHTMLAnchorElement(const HTMLElement* element) { return isHTMLAnchorElement(*element); }
inline bool isHTMLAnchorElement(const Node& node) { return node.isHTMLElement() && isHTMLAnchorElement(toHTMLElement(node)); }
inline bool isHTMLAnchorElement(const Node* node) { ASSERT(node); return isHTMLAnchorElement(*node); }
template <> inline bool isElementOfType<HTMLAnchorElement>(const HTMLElement* element) { return isHTMLAnchorElement(element); }
template <> inline bool isElementOfType<HTMLAnchorElement>(const Element* element) { return isHTMLAnchorElement(element); }

[Andreas Kling]

Created attachment 214058 [details]
Patch

[EFL EWS Bot]

Comment on attachment 214058 [details]
Patch

Attachment 214058 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3980004

[EFL EWS Bot]

Comment on attachment 214058 [details]
Patch

Attachment 214058 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3976004

[kov's GTK+ EWS bot]

Comment on attachment 214058 [details]
Patch

Attachment 214058 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3914010

[Andreas Kling]

Created attachment 214059 [details]
For the land

[WebKit Commit Bot]

Comment on attachment 214059 [details]
For the land

Clearing flags on attachment: 214059

Committed r157343: <http://trac.webkit.org/changeset/157343>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.