Bug 122694 – Factor line box code from RenderText to a class

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

This code can be factored out.

[Antti Koivisto]

Created attachment 214057 [details]
patch

[Andreas Kling]

Comment on attachment 214057 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214057&action=review

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:43
> +        m_first = m_last = textBox;

We should do this on two lines.

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:59
> +        m_first = 0;

nullptr

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:114
> +    m_first = m_last = 0;

nullptr
Also, we should do this on two lines.

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:117
> +InlineTextBox* RenderTextLineBoxes::findNext(int offset, int& pos) const

Crappy name: pos.

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:120
> +        return 0;

nullptr

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:129
> +    pos = (offset > currentOffset ? current->len() : current->len() - (currentOffset - offset) );

Extra space before last ')'

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:143
> +    const InlineTextBox* prev = 0;

nullptr

> Source/WebCore/rendering/RenderTextLineBoxes.h:45
> +    void extract(InlineTextBox*);
> +    void attach(InlineTextBox*);
> +    void remove(InlineTextBox*);

Seems like these should really take references. Maybe in a later patch?

[Antti Koivisto]

http://trac.webkit.org/changeset/157340