Bug 122690 - [sh4] Missing spaces in JITStubsSH4.h
Summary: [sh4] Missing spaces in JITStubsSH4.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-12 01:45 PDT by Julien Brianceau
Modified: 2013-10-12 02:24 PDT (History)
1 user (show)

See Also:


Attachments
Add missing spaces in JITStubsSH4.h (2.98 KB, patch)
2013-10-12 01:49 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-10-12 01:45:35 PDT
Missing spaces in JITStubsSH4.h break the sh4 build when using a C++11 sh4 compiler:

[ 50%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITStubs.cpp.o
In file included from /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:93:0:
/home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubsSH4.h:89:5: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING'
/home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubsSH4.h:113:5: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING'
/home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:427:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING'
/home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:439:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING'
/home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:450:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING'
/home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:463:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING'
[...]
Comment 1 Julien Brianceau 2013-10-12 01:49:02 PDT
Created attachment 214052 [details]
Add missing spaces in JITStubsSH4.h
Comment 2 WebKit Commit Bot 2013-10-12 02:24:12 PDT
Comment on attachment 214052 [details]
Add missing spaces in JITStubsSH4.h

Clearing flags on attachment: 214052

Committed r157335: <http://trac.webkit.org/changeset/157335>
Comment 3 WebKit Commit Bot 2013-10-12 02:24:14 PDT
All reviewed patches have been landed.  Closing bug.