Bug 122680 - Dramatically simplify calculateAdjustedNodes
Summary: Dramatically simplify calculateAdjustedNodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 131949
  Show dependency tree / graph
 
Reported: 2013-10-11 15:29 PDT by Ryosuke Niwa
Modified: 2014-04-21 13:43 PDT (History)
9 users (show)

See Also:

Attachments
Cleanup (8.19 KB, patch)
2013-10-11 15:33 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Cleanup (8.23 KB, patch)
2013-10-11 15:34 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Minor tweaks (8.29 KB, patch)
2013-10-11 15:59 PDT, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-11 15:29:02 PDT 
Dramatically simplify calculateAdjustedNodes
Comment 1 Ryosuke Niwa 2013-10-11 15:33:50 PDT 
Created attachment 214028 [details]
Cleanup
Comment 2 Ryosuke Niwa 2013-10-11 15:34:24 PDT 
Created attachment 214029 [details]
Cleanup
Comment 3 Ryosuke Niwa 2013-10-11 15:59:27 PDT 
Created attachment 214032 [details]
Minor tweaks
Comment 4 Antti Koivisto 2013-10-11 17:53:36 PDT 
Comment on attachment 214032 [details]
Minor tweaks

Note that <details> element implementation still uses InsertionPoints. On the other hand we can assume that any functionality without tests is not working anyway.
Comment 5 Ryosuke Niwa 2013-10-11 19:02:35 PDT 
(In reply to comment #4)
> (From update of attachment 214032 [details])
> Note that <details> element implementation still uses InsertionPoints. On the other hand we can assume that any functionality without tests is not working anyway.

Maybe I didn't phrase it properly but having a single insertion point is okay as long as the content that got inserted into doesn't have a shadow tree.

Since we don't currently expose webkitCreateShadowRoot, this isn't an issue.
Comment 6 Ryosuke Niwa 2013-10-11 19:07:17 PDT 
Committed r157328: <http://trac.webkit.org/changeset/157328>