Bug 122675 – Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2

The "groundwork" is basically a WebIDBFactoryBackend  that stubs out the entry points into the indexed database API, and gives the most basic foundation to build a database process on.

This will break current WK2 clients using the in-process LevelDB implementation.

[Brady Eidson]

Created attachment 214016 [details]
Patch v1 - Lay the most basic groundwork, breaking in-process LevelDB users

[WebKit Commit Bot]

Attachment 214016 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp']" exit_code: 1
Source/WebKit2/CMakeLists.txt:419:  No trailing spaces  [whitespace/trailing] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

(In reply to comment #2)
> Attachment 214016 [details] did not pass style-queue:
> ...
> Source/WebKit2/CMakeLists.txt:419:  No trailing spaces  [whitespace/trailing] [5]
> Total errors found: 1 in 7 files

Fixed locally.

[Brady Eidson]

Created attachment 214022 [details]
Patch v2 - More ENABLE() guards and project file fixes

[Brady Eidson]

http://trac.webkit.org/changeset/157320

If any WK2 port relying on their in-process IDB working needs a temporary #ifdef, we can do that in WebPlatformStrategies.

But as stressed on webkit-dev... it will be *temporary*