Bug 122675 - Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2
Summary: Lay the groundwork for a multi-process aware Indexed DB implementation in Web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-11 12:58 PDT by Brady Eidson
Modified: 2013-10-11 15:11 PDT (History)
7 users (show)

See Also:


Attachments
Patch v1 - Lay the most basic groundwork, breaking in-process LevelDB users (13.35 KB, patch)
2013-10-11 13:12 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch v2 - More ENABLE() guards and project file fixes (14.17 KB, patch)
2013-10-11 13:57 PDT, Brady Eidson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-10-11 12:58:13 PDT
Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2

The "groundwork" is basically a WebIDBFactoryBackend  that stubs out the entry points into the indexed database API, and gives the most basic foundation to build a database process on.

This will break current WK2 clients using the in-process LevelDB implementation.
Comment 1 Brady Eidson 2013-10-11 13:12:22 PDT
Created attachment 214016 [details]
Patch v1 - Lay the most basic groundwork, breaking in-process LevelDB users
Comment 2 WebKit Commit Bot 2013-10-11 13:14:06 PDT
Attachment 214016 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp']" exit_code: 1
Source/WebKit2/CMakeLists.txt:419:  No trailing spaces  [whitespace/trailing] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2013-10-11 13:19:13 PDT
(In reply to comment #2)
> Attachment 214016 [details] did not pass style-queue:
> ...
> Source/WebKit2/CMakeLists.txt:419:  No trailing spaces  [whitespace/trailing] [5]
> Total errors found: 1 in 7 files

Fixed locally.
Comment 4 Brady Eidson 2013-10-11 13:57:04 PDT
Created attachment 214022 [details]
Patch v2 - More ENABLE() guards and project file fixes
Comment 5 Brady Eidson 2013-10-11 15:11:47 PDT
http://trac.webkit.org/changeset/157320

If any WK2 port relying on their in-process IDB working needs a temporary #ifdef, we can do that in WebPlatformStrategies.

But as stressed on webkit-dev... it will be *temporary*