We're about to introduce a PlatformCALayer subclass for remote layer tree hosting which needs to co-exist (for now) with normal Mac PlatformCALayer. In order to do this, let's make PlatformCALayer virtual, and add PlatformCALayerWin and PlatformCALayerMac subclasses.
Created attachment 214127 [details] take one
Attachment 214127 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp', u'Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp', u'Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h', u'Source/WebCore/platform/graphics/win/GraphicsContext3DWin.cpp', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/FullscreenVideoController.cpp']" exit_code: 1 Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:38: The parameter name "platformLayer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:58: The parameter name "animation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:143: The parameter name "layerType" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:143: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:115: The parameter name "animation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:191: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:192: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:193: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:65: The parameter name "animation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:144: The parameter name "layerType" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:144: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:59: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 12 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 214128 [details] take two
Created attachment 214172 [details] take three; fix filtersCanBeComposited
Comment on attachment 214172 [details] take three; fix filtersCanBeComposited Attachment 214172 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3950895
Created attachment 214178 [details] which broke the build
Comment on attachment 214178 [details] which broke the build View in context: https://bugs.webkit.org/attachment.cgi?id=214178&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:153 > +} // namespace WebCore
http://trac.webkit.org/changeset/157419