Bug 122666 - Fix handling of indirect stackmap locations in FTL OSR exit
Summary: Fix handling of indirect stackmap locations in FTL OSR exit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 122487
  Show dependency tree / graph
 
Reported: 2013-10-11 11:44 PDT by Filip Pizlo
Modified: 2013-10-11 18:31 PDT (History)
8 users (show)

See Also:

Attachments
the patch (4.59 KB, patch)
2013-10-11 11:47 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-11 11:44:33 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-10-11 11:47:53 PDT 
Created attachment 214008 [details]
the patch
Comment 2 Mark Hahnenberg 2013-10-11 16:54:19 PDT 
Comment on attachment 214008 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214008&action=review

r=me

> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:70
> +    jit.push(GPRInfo::regT0);

Might be good to comment why we're seemingly randomly pushing here.
Comment 3 Filip Pizlo 2013-10-11 18:31:58 PDT 
Landed in http://trac.webkit.org/changeset/157326