Bug 122655 - Remove preference support for picking the old Web Inspector.
Summary: Remove preference support for picking the old Web Inspector.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-11 10:08 PDT by Timothy Hatcher
Modified: 2013-10-14 11:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.80 KB, patch)
2013-10-11 10:10 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (15.67 KB, patch)
2013-10-11 15:09 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-10-11 10:08:34 PDT 
Remove preference support for picking the old Web Inspector.
Comment 1 Timothy Hatcher 2013-10-11 10:10:13 PDT 
Created attachment 213995 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-10-11 10:14:08 PDT 
<rdar://problem/15208571>
Comment 3 Timothy Hatcher 2013-10-11 10:14:53 PDT 
Comment on attachment 213995 [details]
Patch

This will break the nightlies since WKPreferencesSetInspectorUsesWebKitUserInterface is being removed. Will need a stub.
Comment 4 Timothy Hatcher 2013-10-11 15:09:27 PDT 
Created attachment 214025 [details]
Patch
Comment 5 WebKit Commit Bot 2013-10-11 16:07:32 PDT 
Comment on attachment 214025 [details]
Patch

Clearing flags on attachment: 214025

Committed r157323: <http://trac.webkit.org/changeset/157323>
Comment 6 WebKit Commit Bot 2013-10-11 16:07:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2013-10-14 11:56:01 PDT 
Looks like this needs to be done for Windows as well:

    if (!htmlURLRef)
        htmlURLRef = adoptCF(CFBundleCopyResourceURL(webKitBundle(), CFSTR("inspector"), CFSTR("html"), CFSTR("inspector")));

I'll file a follow-up.