Bug 122653 - The content of the DOM panel for iframes is not updated until the "onload" event
Summary: The content of the DOM panel for iframes is not updated until the "onload" event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-11 09:56 PDT by Alexandru Chiculita
Modified: 2013-10-14 16:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch V1 (10.96 KB, patch)
2013-10-14 14:57 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2013-10-11 09:56:44 PDT
If you open a page with an iframe that takes longer time to load, the webinspector is not going to update the content of the frame until the frame is fully loaded.

The problem is that iframe elements are ubound and bound only on the "loadEventFired" event.
Comment 1 Radar WebKit Bug Importer 2013-10-11 09:56:52 PDT
<rdar://problem/15208386>
Comment 2 Alexandru Chiculita 2013-10-14 14:57:26 PDT
Created attachment 214193 [details]
Patch V1
Comment 3 WebKit Commit Bot 2013-10-14 16:07:03 PDT
Comment on attachment 214193 [details]
Patch V1

Clearing flags on attachment: 214193

Committed r157425: <http://trac.webkit.org/changeset/157425>
Comment 4 WebKit Commit Bot 2013-10-14 16:07:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2013-10-14 16:14:45 PDT
Comment on attachment 214193 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=214193&action=review

Nice! I realize this has landed, but some nits that don't need to be addressed.

> LayoutTests/http/tests/inspector-protocol/resources/slow-test-page.html:4
> +	// Having a script tag so that we force the creationg of a scripting context.

Typo: "creationg"

> LayoutTests/http/tests/inspector-protocol/resources/slow-test-page.html:11
> +	<img src="http://localhost:8000/history/resources/slow-image.php" />

Nit: No need for /> closing tag for self-closing tags in HTML