Bug 122650 - Remove gesture event support from WebCore
Summary: Remove gesture event support from WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2013-10-11 09:44 PDT by Anders Carlsson
Modified: 2013-10-11 12:16 PDT (History)
9 users (show)

See Also:

Attachments
Patch (51.05 KB, patch)
2013-10-11 09:50 PDT, Anders Carlsson 		rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-10-11 09:44:18 PDT 
Remove gesture event support from WebCore
Comment 1 Anders Carlsson 2013-10-11 09:50:01 PDT 
Created attachment 213994 [details]
Patch
Comment 2 Build Bot 2013-10-11 10:26:15 PDT 
Comment on attachment 213994 [details]
Patch

Attachment 213994 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3954167
Comment 3 Build Bot 2013-10-11 11:01:25 PDT 
Comment on attachment 213994 [details]
Patch

Attachment 213994 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3950163
Comment 4 Ryosuke Niwa 2013-10-11 11:11:57 PDT 
It seems like gesture event is enabled by default on Mac port.
Are you sure we want to remove this?
Comment 5 Ryosuke Niwa 2013-10-11 11:12:29 PDT 
Also, it seems like this patch warrants a webkit-dev announcement.
Comment 6 Ryosuke Niwa 2013-10-11 11:29:44 PDT 
This has been announced on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2013-October/025673.html
Comment 7 Ryosuke Niwa 2013-10-11 11:30:29 PDT 
Comment on attachment 213994 [details]
Patch

rs=me but please fix the Mac build. PlatformGestureEvent.h is included in ScrollAnimatorMac.mm.
Comment 8 Build Bot 2013-10-11 12:08:28 PDT 
Comment on attachment 213994 [details]
Patch

Attachment 213994 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3946188
Comment 9 Anders Carlsson 2013-10-11 12:16:39 PDT 
Committed r157316: <http://trac.webkit.org/changeset/157316>