Bug 122649 - Make LayoutState not arena-allocated.
Summary: Make LayoutState not arena-allocated.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-11 08:51 PDT by Andreas Kling
Modified: 2013-10-12 03:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.14 KB, patch)
2013-10-11 08:58 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-11 08:51:53 PDT 
Simplify the memory management of LayoutState.
Comment 1 Andreas Kling 2013-10-11 08:58:22 PDT 
Created attachment 213992 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-11 08:58:57 PDT 
Attachment 213992 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LayoutState.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h']" exit_code: 1
Source/WebCore/rendering/LayoutState.h:67:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-10-12 03:05:12 PDT 
Committed r157336: <http://trac.webkit.org/changeset/157336>