WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122649
Make LayoutState not arena-allocated.
https://bugs.webkit.org/show_bug.cgi?id=122649
Summary
Make LayoutState not arena-allocated.
Andreas Kling
Reported
2013-10-11 08:51:53 PDT
Simplify the memory management of LayoutState.
Attachments
Patch
(10.14 KB, patch)
2013-10-11 08:58 PDT
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-10-11 08:58:22 PDT
Created
attachment 213992
[details]
Patch
WebKit Commit Bot
Comment 2
2013-10-11 08:58:57 PDT
Attachment 213992
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LayoutState.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h']" exit_code: 1 Source/WebCore/rendering/LayoutState.h:67: The parameter name "state" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2013-10-12 03:05:12 PDT
Committed
r157336
: <
http://trac.webkit.org/changeset/157336
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug