Bug 122641 - Remove some dead code from PlatformCALayer*
Summary: Remove some dead code from PlatformCALayer*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-10 23:31 PDT by Tim Horton
Modified: 2013-10-11 12:03 PDT (History)
3 users (show)

See Also:

Attachments
patch (11.21 KB, patch)
2013-10-10 23:44 PDT, Tim Horton 		buildbot: commit-queue-
Details | Formatted Diff | Diff
patch (11.75 KB, patch)
2013-10-11 03:42 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-10 23:31:47 PDT 
There are a bunch of unused getters in PlatformCALayer that we should get rid of before refactoring. Ideally PlatformCALayer would be nearly entirely write-only, but our layer-cloning code poses some problems there.
Comment 1 Tim Horton 2013-10-10 23:44:17 PDT 
Created attachment 213972 [details]
patch
Comment 2 Tim Horton 2013-10-10 23:44:37 PDT 
Ugh, no Win EWS?
Comment 3 Build Bot 2013-10-11 00:25:52 PDT 
Comment on attachment 213972 [details]
patch

Attachment 213972 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3898009
Comment 4 Tim Horton 2013-10-11 03:42:54 PDT 
Created attachment 213979 [details]
patch
Comment 5 WebKit Commit Bot 2013-10-11 12:03:02 PDT 
Comment on attachment 213979 [details]
patch

Clearing flags on attachment: 213979

Committed r157314: <http://trac.webkit.org/changeset/157314>
Comment 6 WebKit Commit Bot 2013-10-11 12:03:05 PDT 
All reviewed patches have been landed.  Closing bug.