Do a bit of optimization and cleanup in the HTMLElement class
Created attachment 213970 [details] Patch
Comment on attachment 213970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213970&action=review r=me > Source/WebCore/html/HTMLElement.cpp:375 > + RefPtr<Text> textNode = &node; > RefPtr<Text> textNext = toText(next); These two could be Ref<Text> to skip some null checks. > Source/WebCore/html/HTMLElement.cpp:740 > - if (equalIgnoringCase(value, "yes") || equalIgnoringCase(value, "")) > + if (equalIgnoringCase(value, "yes") || value.isEmpty()) Looks like we need isEmptyIgnoringCase(). ;) > Source/WebCore/html/HTMLElement.cpp:752 > + for (const Element* element = this; element; element = element->parentElement()) { > + if (!element->isHTMLElement()) > + continue; This would look slightly nicer as a loop over ancestorsOfType<HTMLElement>(this).
Comment on attachment 213970 [details] Patch Attachment 213970 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3953027
Dang, I didn't spot the bogus "string->parsedLength()" calls.
Comment on attachment 213970 [details] Patch Attachment 213970 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3953029
Comment on attachment 213970 [details] Patch Attachment 213970 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3403112
Comment on attachment 213970 [details] Patch Attachment 213970 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3889011
Comment on attachment 213970 [details] Patch Attachment 213970 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3867103
Comment on attachment 213970 [details] Patch Attachment 213970 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/3952018
Committed r157300: <http://trac.webkit.org/changeset/157300>