Bug 122639 - Use unique_ptr instead of delete in a few places
Summary: Use unique_ptr instead of delete in a few places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-10 23:12 PDT by Darin Adler
Modified: 2013-10-12 07:14 PDT (History)
7 users (show)

See Also:

Attachments
Patch (35.35 KB, patch)
2013-10-10 23:23 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (45.46 KB, patch)
2013-10-10 23:43 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (54.04 KB, patch)
2013-10-11 19:12 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (54.04 KB, patch)
2013-10-11 19:31 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (57.08 KB, patch)
2013-10-11 20:03 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-10-10 23:12:19 PDT 
Use unique_ptr instead of delete in a few places
Comment 1 Darin Adler 2013-10-10 23:23:51 PDT 
Created attachment 213969 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-10 23:31:50 PDT 
Comment on attachment 213969 [details]
Patch

Attachment 213969 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3929015
Comment 3 EFL EWS Bot 2013-10-10 23:43:20 PDT 
Comment on attachment 213969 [details]
Patch

Attachment 213969 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3948016
Comment 4 Darin Adler 2013-10-10 23:43:42 PDT 
Created attachment 213971 [details]
Patch
Comment 5 EFL EWS Bot 2013-10-10 23:50:47 PDT 
Comment on attachment 213971 [details]
Patch

Attachment 213971 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3945011
Comment 6 EFL EWS Bot 2013-10-10 23:53:03 PDT 
Comment on attachment 213971 [details]
Patch

Attachment 213971 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3885027
Comment 7 Build Bot 2013-10-11 00:24:45 PDT 
Comment on attachment 213971 [details]
Patch

Attachment 213971 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3945018
Comment 8 kov's GTK+ EWS bot 2013-10-11 00:38:57 PDT 
Comment on attachment 213971 [details]
Patch

Attachment 213971 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3403120
Comment 9 Darin Adler 2013-10-11 19:12:23 PDT 
Created attachment 214041 [details]
Patch
Comment 10 EFL EWS Bot 2013-10-11 19:17:34 PDT 
Comment on attachment 214041 [details]
Patch

Attachment 214041 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3954303
Comment 11 EFL EWS Bot 2013-10-11 19:19:01 PDT 
Comment on attachment 214041 [details]
Patch

Attachment 214041 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3867356
Comment 12 Darin Adler 2013-10-11 19:31:03 PDT 
Created attachment 214043 [details]
Patch
Comment 13 EFL EWS Bot 2013-10-11 19:41:55 PDT 
Comment on attachment 214043 [details]
Patch

Attachment 214043 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3776362
Comment 14 Darin Adler 2013-10-11 20:03:01 PDT 
Created attachment 214045 [details]
Patch
Comment 15 WebKit Commit Bot 2013-10-12 07:14:02 PDT 
Comment on attachment 214045 [details]
Patch

Clearing flags on attachment: 214045

Committed r157337: <http://trac.webkit.org/changeset/157337>
Comment 16 WebKit Commit Bot 2013-10-12 07:14:05 PDT 
All reviewed patches have been landed.  Closing bug.