Bug 122629 - FTL shouldn't pass i1's into llvm.webkit.stackmap's
Summary: FTL shouldn't pass i1's into llvm.webkit.stackmap's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-10 18:50 PDT by Filip Pizlo
Modified: 2013-10-10 23:36 PDT (History)
9 users (show)

See Also:

Attachments
the patch (1.45 KB, patch)
2013-10-10 18:52 PDT, Filip Pizlo 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-10 18:50:28 PDT 
Patch forthcoming.

<rdar://problem/15203037>
Comment 1 Filip Pizlo 2013-10-10 18:52:28 PDT 
Created attachment 213953 [details]
the patch
Comment 2 Sam Weinig 2013-10-10 19:38:10 PDT 
Comment on attachment 213953 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213953&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        FTL shouldn't pass i1's into llvm.webkit.stackmap's
> +        https://bugs.webkit.org/show_bug.cgi?id=122629
> +        <rdar://problem/15203037>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * ftl/FTLLowerDFGToLLVM.cpp:
> +        (JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

Why?
Comment 3 Nadav Rotem 2013-10-10 23:22:16 PDT 
i1 is not a legal type because it does not fit into a register on most targets.  LLVM can't "legalize" stack maps because we did not add support for stack maps with illegal types.  r=me.
Comment 4 Filip Pizlo 2013-10-10 23:31:51 PDT 
(In reply to comment #3)
> i1 is not a legal type because it does not fit into a register on most targets.  LLVM can't "legalize" stack maps because we did not add support for stack maps with illegal types.  r=me.

What Nadav said.

I'll put this into the comment.

Basically, the stackmap support that LLVM provides us with requires us to legalize types ourselves.  Which is fine.  I had just forgotten that rule and accidentally let i1's slip through.
Comment 5 Filip Pizlo 2013-10-10 23:36:43 PDT 
Landed in http://trac.webkit.org/changeset/157293