Bug 122629 – FTL shouldn't pass i1's into llvm.webkit.stackmap's

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

<rdar://problem/15203037>

[Filip Pizlo]

Created attachment 213953 [details]
the patch

[Sam Weinig]

Comment on attachment 213953 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213953&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        FTL shouldn't pass i1's into llvm.webkit.stackmap's
> +        https://bugs.webkit.org/show_bug.cgi?id=122629
> +        <rdar://problem/15203037>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * ftl/FTLLowerDFGToLLVM.cpp:
> +        (JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

Why?

[Nadav Rotem]

i1 is not a legal type because it does not fit into a register on most targets.  LLVM can't "legalize" stack maps because we did not add support for stack maps with illegal types.  r=me.

[Filip Pizlo]

(In reply to comment #3)
> i1 is not a legal type because it does not fit into a register on most targets.  LLVM can't "legalize" stack maps because we did not add support for stack maps with illegal types.  r=me.

What Nadav said.

I'll put this into the comment.

Basically, the stackmap support that LLVM provides us with requires us to legalize types ourselves.  Which is fine.  I had just forgotten that rule and accidentally let i1's slip through.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/157293