Bug 122616 - CallbackData unnecessarily caches the JSValue for currentThis
Summary: CallbackData unnecessarily caches the JSValue for currentThis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-10 13:01 PDT by Mark Hahnenberg
Modified: 2013-10-10 13:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2013-10-10 13:08 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-10-10 13:01:26 PDT 
CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores. +[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for CallbackData to do its own caching.
Comment 1 Mark Hahnenberg 2013-10-10 13:08:04 PDT 
Created attachment 213919 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-10 13:48:48 PDT 
Comment on attachment 213919 [details]
Patch

Clearing flags on attachment: 213919

Committed r157249: <http://trac.webkit.org/changeset/157249>
Comment 3 WebKit Commit Bot 2013-10-10 13:48:50 PDT 
All reviewed patches have been landed.  Closing bug.