Bug 122609 - REGRESSION (r157205?): Leaks in XPath
Summary: REGRESSION (r157205?): Leaks in XPath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-10 11:40 PDT by Alexey Proskuryakov
Modified: 2013-10-10 20:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2013-10-10 20:11 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-10 11:40:25 PDT
I started seeing leaks in XPath recently, looks like this broke yesterday or the day before.

The bot <http://build.webkit.org/LeaksViewer/> sees them, and I could reproduce locally with:

run-webkit-tests --child-processes=1 --leaks fast/xpath
Comment 1 Darin Adler 2013-10-10 12:05:50 PDT
I plan to work on this tonight.
Comment 2 Darin Adler 2013-10-10 20:11:46 PDT
Created attachment 213960 [details]
Patch
Comment 3 Andreas Kling 2013-10-10 20:15:38 PDT
Comment on attachment 213960 [details]
Patch

LGTM
Comment 4 WebKit Commit Bot 2013-10-10 20:50:13 PDT
Comment on attachment 213960 [details]
Patch

Clearing flags on attachment: 213960

Committed r157287: <http://trac.webkit.org/changeset/157287>
Comment 5 WebKit Commit Bot 2013-10-10 20:50:15 PDT
All reviewed patches have been landed.  Closing bug.