RESOLVED FIXED 122607
Store uniform type information in WebGLUniformationLocation 
https://bugs.webkit.org/show_bug.cgi?id=122607
Summary Store uniform type information in WebGLUniformationLocation
Roger Fong
Reported 2013-10-10 11:05:23 PDT
We should store type information here so that we don't have to loop through all the uniforms and find it everytime we call getUniform.
Attachments
patch (14.60 KB, patch)
2013-10-10 11:06 PDT, Roger Fong 		no flags
DetailsFormatted DiffDiff
w/ style fix (14.59 KB, patch)
2013-10-10 12:04 PDT, Roger Fong 		dino: review+
roger_fong: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-10-10 11:06:49 PDT
Created attachment 213903 [details] patch
WebKit Commit Bot
Comment 2 2013-10-10 11:08:24 PDT
Attachment 213903 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLUniformLocation.cpp', u'Source/WebCore/html/canvas/WebGLUniformLocation.h']" exit_code: 1 Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3011: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Roger Fong
Comment 3 2013-10-10 12:04:22 PDT
Created attachment 213910 [details] w/ style fix
Roger Fong
Comment 4 2013-10-10 13:18:01 PDT
Committed: http://trac.webkit.org/changeset/157247
Note You need to log in before you can comment on or make changes to this bug.