Bug 122607 - Store uniform type information in WebGLUniformationLocation
Summary: Store uniform type information in WebGLUniformationLocation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 122610 126411
  Show dependency tree / graph
 
Reported: 2013-10-10 11:05 PDT by Roger Fong
Modified: 2014-01-02 16:31 PST (History)
6 users (show)

See Also:

Attachments
patch (14.60 KB, patch)
2013-10-10 11:06 PDT, Roger Fong 		no flags Details | Formatted Diff | Diff
w/ style fix (14.59 KB, patch)
2013-10-10 12:04 PDT, Roger Fong 		dino: review+
roger_fong: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-10-10 11:05:23 PDT 
We should store type information here so that we don't have to loop through all the uniforms and find it everytime we call getUniform.
Comment 1 Roger Fong 2013-10-10 11:06:49 PDT 
Created attachment 213903 [details]
patch
Comment 2 WebKit Commit Bot 2013-10-10 11:08:24 PDT 
Attachment 213903 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLUniformLocation.cpp', u'Source/WebCore/html/canvas/WebGLUniformLocation.h']" exit_code: 1
Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3011:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Roger Fong 2013-10-10 12:04:22 PDT 
Created attachment 213910 [details]
w/ style fix
Comment 4 Roger Fong 2013-10-10 13:18:01 PDT 
Committed: http://trac.webkit.org/changeset/157247