Bug 122601 - [CSS Shapes] clampToUnsigned() should return unsigned, not int
Summary: [CSS Shapes] clampToUnsigned() should return unsigned, not int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on: 121619
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-10 08:34 PDT by Hans Muller
Modified: 2013-10-10 12:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2013-10-10 09:47 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-10-10 08:34:24 PDT 
The patch for https://bugs.webkit.org/show_bug.cgi?id=121619 included a MathExtras.h clampToUnsigned() inline. I'd mistakenly given it an "int" return type.  Of course the return type should be unsigned.
Comment 1 Hans Muller 2013-10-10 09:47:48 PDT 
Created attachment 213893 [details]
Patch

Corrected clampToUnsigned().
Comment 2 WebKit Commit Bot 2013-10-10 12:21:27 PDT 
Comment on attachment 213893 [details]
Patch

Clearing flags on attachment: 213893

Committed r157238: <http://trac.webkit.org/changeset/157238>
Comment 3 WebKit Commit Bot 2013-10-10 12:21:29 PDT 
All reviewed patches have been landed.  Closing bug.