Bug 122600 – [ATK] Missing checks in returnIfWebKitAccessibleIsInvalid

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Mario Sanchez Prada]

Besides checking if an ATK wrapper has been detached to determine whether it's invalid or not, we also need to check if the coreObject's document is null, since that might have been invalidated even before we called any function of the ATK API.

Actually, this additional check can save us from calling updateBackingStore, so bonus points

[Radar WebKit Bug Importer]

<rdar://problem/15197317>

[Mario Sanchez Prada]

Created attachment 213886 [details]
Patch proposal

[chris fleizach]

Comment on attachment 213886 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=213886&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:46
>          if (webkitAccessibleIsDetached(webkitAccessible)) \

does webkitAccessibleIsDetached also check if the document is null?

[Mario Sanchez Prada]

(In reply to comment #3)
> (From update of attachment 213886 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213886&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:46
> >          if (webkitAccessibleIsDetached(webkitAccessible)) \
> 
> does webkitAccessibleIsDetached also check if the document is null?

No. Only if the wrapped object is no longer a valid AccessibilityObject

[WebKit Commit Bot]

Comment on attachment 213886 [details]
Patch proposal

Clearing flags on attachment: 213886

Committed r157227: <http://trac.webkit.org/changeset/157227>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.