Bug 122590 - Move inheritance of PopupMenuClient from RenderSearchField to RenderTextControlSingleLine
Summary: Move inheritance of PopupMenuClient from RenderSearchField to RenderTextContr...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on:
Blocks: 98934
  Show dependency tree / graph
 
Reported: 2013-10-10 01:13 PDT by ChangSeok Oh
Modified: 2014-01-10 09:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.82 KB, patch)
2013-10-11 00:08 PDT, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (9.69 KB, patch)
2013-10-11 01:26 PDT, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-10-10 01:13:16 PDT 
Not only search field but also other single line text fields(text, email etc) could have a popup menu to suggest previous input or show predefined options like datalist.
So I think it would be better that RenderTextControlSingleLine inherits PopupMenuClient than RenderSearchField.
This bug just changes the inheritance status, but eventually I'm going to fill the inherited methods of RenderTextControlSingleLine with code related with datalist.

You can see a rough sketch here. http://cgit.collabora.com/git/user/kevino/WebKit.git/commit/?h=datalist&id=8a931ede66872520559af1f0564cbfa0633fbb14
Comment 1 ChangSeok Oh 2013-10-11 00:08:07 PDT 
Created attachment 213973 [details]
Patch
Comment 2 Build Bot 2013-10-11 00:13:15 PDT 
Comment on attachment 213973 [details]
Patch

Attachment 213973 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3953033
Comment 3 Build Bot 2013-10-11 00:34:45 PDT 
Comment on attachment 213973 [details]
Patch

Attachment 213973 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3946029
Comment 4 ChangSeok Oh 2013-10-11 01:26:10 PDT 
Created attachment 213976 [details]
Patch
Comment 5 Gustavo Noronha (kov) 2013-10-16 01:32:14 PDT 
Comment on attachment 213976 [details]
Patch

I don't feel qualified to judge whether this change makes sense on its merits, but I think it would be better to have the patch be the actual functional change instead of just the ground work.
Comment 6 ChangSeok Oh 2014-01-10 09:02:16 PST 
The approach is changed not to use GtkPopup