Make EventDispatcher::dispatch comprehensible
Created attachment 213851 [details] Cleanup
This patch should make Darin & Sam very happy :)
Comment on attachment 213851 [details] Cleanup Attachment 213851 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3485155 New failing tests: animations/animation-border-overflow.html accessibility/axpress-on-aria-button.html animations/3d/matrix-transform-type-animation.html compositing/self-painting-layers2.html animations/3d/state-at-end-event-transform.html animations/added-while-suspended.html compositing/video-page-visibility.html animations/animation-add-events-in-handler.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html accessibility/file-upload-button-with-axpress.html http/tests/appcache/video.html accessibility/loading-iframe-sends-notification.html compositing/layers-inside-overflow-scroll.html compositing/animation/state-at-end-event-transform-layer.html accessibility/label-element-press.html compositing/animation/animation-compositing.html compositing/self-painting-layers.html animations/3d/change-transform-in-end-event.html compositing/geometry/clipped-video-controller.html compositing/contents-scale/animating.html http/tests/cache/cancel-during-failure-crash.html canvas/philip/tests/security.dataURI.html compositing/iframes/layout-on-compositing-change.html compositing/iframes/iframe-position-absolute-with-padding-percentage-crash.html canvas/philip/tests/2d.pattern.modify.image1.html http/tests/appcache/non-html.xhtml canvas/philip/tests/2d.pattern.modify.image2.html compositing/geometry/limit-layer-bounds-opacity-transition.html compositing/layer-creation/animation-overlap-with-children.html
Created attachment 213853 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 213851 [details] Cleanup Attachment 213851 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3489190 New failing tests: animations/animation-border-overflow.html accessibility/axpress-on-aria-button.html animations/3d/matrix-transform-type-animation.html compositing/self-painting-layers2.html animations/3d/state-at-end-event-transform.html animations/added-while-suspended.html compositing/video-page-visibility.html animations/animation-add-events-in-handler.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html accessibility/file-upload-button-with-axpress.html http/tests/appcache/video.html accessibility/loading-iframe-sends-notification.html compositing/layers-inside-overflow-scroll.html compositing/animation/state-at-end-event-transform-layer.html accessibility/label-element-press.html compositing/animation/animation-compositing.html compositing/self-painting-layers.html animations/3d/change-transform-in-end-event.html compositing/geometry/clipped-video-controller.html compositing/contents-scale/animating.html http/tests/cache/cancel-during-failure-crash.html canvas/philip/tests/security.dataURI.html compositing/iframes/layout-on-compositing-change.html compositing/iframes/iframe-position-absolute-with-padding-percentage-crash.html canvas/philip/tests/2d.pattern.modify.image1.html http/tests/appcache/non-html.xhtml canvas/philip/tests/2d.pattern.modify.image2.html compositing/geometry/limit-layer-bounds-opacity-transition.html compositing/layer-creation/animation-overlap-with-children.html
Created attachment 213854 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 213856 [details] Fixed the regression
Comment on attachment 213856 [details] Fixed the regression View in context: https://bugs.webkit.org/attachment.cgi?id=213856&action=review r=me, I love that you are doing this. > Source/WebCore/ChangeLog:38 > + (WebCore::Node::handleLocalEvents): Now takes Event& now. now + now! > Source/WebCore/dom/EventContext.cpp:87 > + if (m_relatedTarget.get() && event.isMouseEvent()) > + toMouseEvent(event).setRelatedTarget(m_relatedTarget.get()); > + else if (m_relatedTarget.get() && event.isFocusEvent()) > + toFocusEvent(event).setRelatedTarget(m_relatedTarget.get()); I would wrap this in a single null check like so: if (m_relatedTarget) { ... } > Source/WebCore/dom/EventDispatcher.cpp:102 > +static void callDefaultEventHanldersInTheBubblingOrder(Event& event, const EventPath& path) Typo, hanlders. > Source/WebCore/dom/EventDispatcher.cpp:186 > + if (isHTMLInputElement(m_node.get())) > + toHTMLInputElement(m_node.get())->willDispatchEvent(*m_event.get(), clickHandlingState); I'd use *m_node instead of m_node.get() here. > Source/WebCore/dom/EventDispatcher.cpp:196 > + toHTMLInputElement(m_node.get())->didDispatchClickEvent(*m_event.get(), clickHandlingState); Same here.
Committed r157210: <http://trac.webkit.org/changeset/157210>