Bug 122586 - Move the rest of EventRetargeter functions to EventPath
Summary: Move the rest of EventRetargeter functions to EventPath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-09 20:18 PDT by Ryosuke Niwa
Modified: 2013-10-10 12:47 PDT (History)
10 users (show)

See Also:


Attachments
Cleanup (13.36 KB, patch)
2013-10-09 20:23 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Updated for ToT (13.41 KB, patch)
2013-10-09 20:27 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed EFL build (13.39 KB, patch)
2013-10-09 21:18 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Another EFL build fix (13.40 KB, patch)
2013-10-09 21:34 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Yet another EFL build fix (13.40 KB, patch)
2013-10-09 21:53 PDT, Ryosuke Niwa
kling: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-09 20:18:22 PDT
Move the rest of EventRetargeter functions to EventPath
Comment 1 Ryosuke Niwa 2013-10-09 20:23:32 PDT
Created attachment 213846 [details]
Cleanup
Comment 2 Ryosuke Niwa 2013-10-09 20:27:06 PDT
Created attachment 213847 [details]
Updated for ToT
Comment 3 EFL EWS Bot 2013-10-09 20:47:26 PDT
Comment on attachment 213847 [details]
Updated for ToT

Attachment 213847 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3848042
Comment 4 EFL EWS Bot 2013-10-09 20:53:17 PDT
Comment on attachment 213847 [details]
Updated for ToT

Attachment 213847 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3525125
Comment 5 Ryosuke Niwa 2013-10-09 21:18:44 PDT
Created attachment 213849 [details]
Fixed EFL build
Comment 6 EFL EWS Bot 2013-10-09 21:21:35 PDT
Comment on attachment 213849 [details]
Fixed EFL build

Attachment 213849 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3558123
Comment 7 EFL EWS Bot 2013-10-09 21:23:14 PDT
Comment on attachment 213849 [details]
Fixed EFL build

Attachment 213849 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3662030
Comment 8 Ryosuke Niwa 2013-10-09 21:34:44 PDT
Created attachment 213850 [details]
Another EFL build fix
Comment 9 Ryosuke Niwa 2013-10-09 21:53:22 PDT
Created attachment 213852 [details]
Yet another EFL build fix
Comment 10 WebKit Commit Bot 2013-10-10 01:25:58 PDT
Comment on attachment 213852 [details]
Yet another EFL build fix

Rejecting attachment 213852 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 213852, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
d at 165 (offset 60 lines).
Hunk #3 succeeded at 175 (offset 60 lines).
Hunk #4 FAILED at 255.
1 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/dom/EventDispatcher.cpp.rej
patching file Source/WebCore/dom/EventDispatcher.h
patching file Source/WebCore/dom/EventRetargeter.cpp
patching file Source/WebCore/dom/EventRetargeter.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/3485190
Comment 11 Ryosuke Niwa 2013-10-10 12:47:59 PDT
Committed r157242: <http://trac.webkit.org/changeset/157242>