WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122582
Kill some RenderObject::firstChildSlow/lastChildSlow usage.
https://bugs.webkit.org/show_bug.cgi?id=122582
Summary
Kill some RenderObject::firstChildSlow/lastChildSlow usage.
Andreas Kling
Reported
2013-10-09 17:59:34 PDT
LVR
Attachments
Patch
(5.39 KB, patch)
2013-10-09 18:00 PDT
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
Patch for landing
(5.40 KB, patch)
2013-10-09 18:04 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-10-09 18:00:53 PDT
Created
attachment 213839
[details]
Patch
Antti Koivisto
Comment 2
2013-10-09 18:02:46 PDT
Comment on
attachment 213839
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=213839&action=review
> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:391 > else if (m_renderer->isAnonymousBlock() && lastChildHasContinuation(m_renderer)) { > - RenderObject* lastParent = endOfContinuations(m_renderer->lastChildSlow())->parent(); > + RenderElement* lastParent = endOfContinuations(m_renderer->lastChildSlow())->parent();
You can remove this lastChildSlow too. m_renderer->isAnonymousBlock()
Andreas Kling
Comment 3
2013-10-09 18:04:58 PDT
Created
attachment 213840
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2013-10-09 18:36:05 PDT
Comment on
attachment 213840
[details]
Patch for landing Clearing flags on attachment: 213840 Committed
r157202
: <
http://trac.webkit.org/changeset/157202
>
WebKit Commit Bot
Comment 5
2013-10-09 18:36:07 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug