Bug 122582 - Kill some RenderObject::firstChildSlow/lastChildSlow usage.
Summary: Kill some RenderObject::firstChildSlow/lastChildSlow usage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-09 17:59 PDT by Andreas Kling
Modified: 2013-10-09 18:36 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.39 KB, patch)
2013-10-09 18:00 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (5.40 KB, patch)
2013-10-09 18:04 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-09 17:59:34 PDT
LVR
Comment 1 Andreas Kling 2013-10-09 18:00:53 PDT
Created attachment 213839 [details]
Patch
Comment 2 Antti Koivisto 2013-10-09 18:02:46 PDT
Comment on attachment 213839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213839&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:391
>      else if (m_renderer->isAnonymousBlock() && lastChildHasContinuation(m_renderer)) {
> -        RenderObject* lastParent = endOfContinuations(m_renderer->lastChildSlow())->parent();
> +        RenderElement* lastParent = endOfContinuations(m_renderer->lastChildSlow())->parent();

You can remove this lastChildSlow too. m_renderer->isAnonymousBlock()
Comment 3 Andreas Kling 2013-10-09 18:04:58 PDT
Created attachment 213840 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-10-09 18:36:05 PDT
Comment on attachment 213840 [details]
Patch for landing

Clearing flags on attachment: 213840

Committed r157202: <http://trac.webkit.org/changeset/157202>
Comment 5 WebKit Commit Bot 2013-10-09 18:36:07 PDT
All reviewed patches have been landed.  Closing bug.