Bug 122574 – AX: VoiceOver speaking too much when group elements with tabindex=-1 are used

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

When a <div> has a tabindex=-1, it is having the affecting of causing it's AXTitle to be calculated by concatenating all the children.

This causes VO to double-speak lots of information.

We should not consider tabindex=-1 not meet this criteria we are using to determine whether to calculate the info

The problem can be seen by visiting
   http://webaim.org/techniques/forms/controls#checkbox 
with VoiceOver

<rdar://problem/15190911>

[Radar WebKit Bug Importer]

<rdar://problem/15191007>

[chris fleizach]

Created attachment 213830 [details]
patch

[Mario Sanchez Prada]

Comment on attachment 213830 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213830&action=review

Looks good to me. I've just made a couple of minor comments for your consideration before landing.

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1325
> +        useTextUnderElement = true;
> +        
> +        // If a node uses a negative tabindex, do not expose it as a generic focusable element, because keyboard focus management
> +        // will never land on this specific element.
> +        Node* node = this->node();
> +        if (node && node->isElementNode() && toElement(node)->tabIndex() < 0)
> +            useTextUnderElement = false;

Probably a pointless suggestion, but what about assigning useTextUnderElement once only? 

e.g: useTextUnderElement = !(node && node->isElementNode() && toElement(node)->tabIndex() < 0);

> LayoutTests/accessibility/negative-tabindex-does-not-expose-label.html:18
> +    
> +

One of these empty lines are not needed

[chris fleizach]

http://trac.webkit.org/changeset/157231

with mario's suggestions