Bug 122568 - [Win] Check for MathML Fonts and warn user if they are missing
Summary: [Win] Check for MathML Fonts and warn user if they are missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 156838
  Show dependency treegraph
 
Reported: 2013-10-09 12:56 PDT by Brent Fulgham
Modified: 2016-04-21 01:51 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.54 KB, patch)
2013-10-09 13:30 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (3.51 KB, patch)
2013-10-09 15:25 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2013-10-09 15:34 PDT, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-10-09 12:56:44 PDT
Users who wish to use the MathML feature on Windows need to make sure they have the proper fonts installed.

Several math fonts are available in a convenient installer from the Mozilla site (https://developer.mozilla.org/@api/deki/files/6388/=MathML-fonts.msi).

We should check for our key MathML fonts and notify the user if they are missing so they can resolve this problem before attempting to use the feature.
Comment 1 Brent Fulgham 2013-10-09 13:30:54 PDT
Created attachment 213805 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2013-10-09 13:35:20 PDT
I'm wondering if the link to the Windows installer is really stable. In particular, it might change if Mozilla folks add/update fonts. Perhaps a better URL is https://developer.mozilla.org/en-US/docs/Mozilla/MathML_Project/Fonts
Comment 3 Brent Fulgham 2013-10-09 15:24:28 PDT
(In reply to comment #2)
> I'm wondering if the link to the Windows installer is really stable. In particular, it might change if Mozilla folks add/update fonts. Perhaps a better URL is https://developer.mozilla.org/en-US/docs/Mozilla/MathML_Project/Fonts

That seems like a good idea.  I found that the site will actually redirect you properly (based on language settings) to the appropriate page, so I propose:

https://developer.mozilla.org/Mozilla/MathML_Project/Fonts
Comment 4 Brent Fulgham 2013-10-09 15:25:46 PDT
Created attachment 213822 [details]
Patch
Comment 5 Tim Horton 2013-10-09 15:34:31 PDT
Comment on attachment 213822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213822&action=review

> Tools/Scripts/webkitdirs.pm:1494
>      chomp($svnVersion);
> -    if (!$? and $svnVersion =~ /1\.8\./) {
> +    if (!$? and $svnVersion =~ /1\.8e./) {
>          print "svn 1.7.10 is known to be compatible with our servers. You are running $svnVersion,\nwhich may not work properly.\n"

No.
Comment 6 Brent Fulgham 2013-10-09 15:34:44 PDT
Created attachment 213824 [details]
Patch
Comment 7 Tim Horton 2013-10-09 15:36:07 PDT
Comment on attachment 213824 [details]
Patch

Better!
Comment 8 Brent Fulgham 2013-10-09 15:37:45 PDT
Committed r157191: <http://trac.webkit.org/changeset/157191>