Bug 122557 - Change to std::unique_ptr breaks wtf/DataLog.cpp when DATA_LOG_TO_FILE set to 1
Summary: Change to std::unique_ptr breaks wtf/DataLog.cpp when DATA_LOG_TO_FILE set to 1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-09 10:00 PDT by Michael Saboff
Modified: 2013-10-09 11:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2013-10-09 10:03 PDT, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-10-09 10:00:39 PDT 
After the recent change to std::unique_ptr, leakPtr() is no longer valid on the line:
    file = FilePrintStream::open(actualFilename, "w").leakPtr();
Comment 1 Michael Saboff 2013-10-09 10:03:53 PDT 
Created attachment 213789 [details]
Patch
Comment 2 Michael Saboff 2013-10-09 11:20:51 PDT 
Committed r157176: <http://trac.webkit.org/changeset/157176>