Bug 122548 – Add GTK 64 bits release to the buildbot dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gustavo Noronha (kov)]

Add GTK 64 bits release to the buildbot dashboard

[Gustavo Noronha (kov)]

Created attachment 213769 [details]
Patch

[Gustavo Noronha (kov)]

Darin was annoyed by the lack of GTK/EFL in the dashboard, so I assume he'll be interested in this one =)

[Darin Adler]

Comment on attachment 213769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213769&action=review

> Tools/ChangeLog:8
> +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.

Does the image really need to be on a white circle? Wouldn’t it be better to have it on a transparent background?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:140
> +    content: -webkit-image-set(url(../Images/GTK.png) 1x);

Doesn’t seem helpful to use an image set for a single image.

[WebKit Commit Bot]

Comment on attachment 213769 [details]
Patch

Clearing flags on attachment: 213769

Committed r157175: <http://trac.webkit.org/changeset/157175>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Gustavo Noronha (kov)]

(In reply to comment #3)
> > Tools/ChangeLog:8
> > +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
> 
> Does the image really need to be on a white circle? Wouldn’t it be better to have it on a transparent background?

Yeah, it looks weird without the white circle because the dashboard page is beige and it bleeds through inside the outer white circle. Also, if the white bit is not a circle covering that much of the image size it bleeds outside the outer circle and looks bad.
 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:140
> > +    content: -webkit-image-set(url(../Images/GTK.png) 1x);
> 
> Doesn’t seem helpful to use an image set for a single image.

Oops, I meant to try to find a bigger version of the logo but forgot I had left this like this after spending too much of my mental energy using the gimp for editing the image ;) thanks!