Bug 122543 - [CSSRegions] Use RenderStyle::hasFlowFrom when needed
Summary: [CSSRegions] Use RenderStyle::hasFlowFrom when needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-09 01:24 PDT by Mihnea Ovidenie
Modified: 2013-10-22 01:26 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2013-10-09 01:27 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Patch 2 (5.88 KB, patch)
2013-10-09 02:11 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Patch for landing (7.21 KB, patch)
2013-10-22 00:23 PDT, Mihnea Ovidenie 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2013-10-09 01:24:52 PDT 
Instead of direct checks for !style()->regionThread().isNull().
Comment 1 Mihnea Ovidenie 2013-10-09 01:27:27 PDT 
Created attachment 213762 [details]
Patch
Comment 2 Andrei Bucur 2013-10-09 01:33:13 PDT 
I think "hasFlowFrom" is a better function name. It's also in line with existing accessors like "hasOpacity, hasPadding" etc.
Comment 3 Mihnea Ovidenie 2013-10-09 02:11:39 PDT 
Created attachment 213764 [details]
Patch 2
Comment 4 Mihnea Ovidenie 2013-10-09 02:48:21 PDT 
(In reply to comment #2)
> I think "hasFlowFrom" is a better function name. It's also in line with existing accessors like "hasOpacity, hasPadding" etc.

Agree, maybe we should also change RenderStyle members m_regionThread to m_flowFrom.
Comment 5 Dave Hyatt 2013-10-21 12:17:28 PDT 
Comment on attachment 213764 [details]
Patch 2

r=me
Comment 6 Mihnea Ovidenie 2013-10-22 00:23:13 PDT 
Created attachment 214825 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-10-22 01:26:31 PDT 
Comment on attachment 214825 [details]
Patch for landing

Clearing flags on attachment: 214825

Committed r157779: <http://trac.webkit.org/changeset/157779>
Comment 8 WebKit Commit Bot 2013-10-22 01:26:33 PDT 
All reviewed patches have been landed.  Closing bug.