Bug 122540 – AX: VoiceOver does not speak aria-expanded state on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

See

http://pauljadam.com/demos/aria-expanded.html

<rdar://problem/15176155>

[chris fleizach]

Created attachment 213756 [details]
patch

[Mario Sanchez Prada]

Comment on attachment 213756 [details]
patch

I've observed you're not exposing canSetExpandedAttribute() at all in this IOS wrapper, which is something you do in the Mac one by means of the attributeName() method:

    - (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
    {
    [...]
        if ([attributeName isEqualToString:NSAccessibilityDisclosingAttribute])
            return m_object->canSetExpandedAttribute();
    [...]
    }

In ATK we expose the very same thing with ATK_STATE_EXPANDABLE, so that's it got my attention. 

Anyway, just pointing it out in case it was not intentional. The current patch is Ok in any case.

[chris fleizach]

(In reply to comment #2)
> (From update of attachment 213756 [details])
> I've observed you're not exposing canSetExpandedAttribute() at all in this IOS wrapper, which is something you do in the Mac one by means of the attributeName() method:
> 
>     - (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
>     {
>     [...]
>         if ([attributeName isEqualToString:NSAccessibilityDisclosingAttribute])
>             return m_object->canSetExpandedAttribute();
>     [...]
>     }
> 
> In ATK we expose the very same thing with ATK_STATE_EXPANDABLE, so that's it got my attention. 
> 
> Anyway, just pointing it out in case it was not intentional. The current patch is Ok in any case.

Thanks for looking at this. On iOS, we don't have a notion of attribute names. Properties are just exposed and queried for when desired

[WebKit Commit Bot]

Comment on attachment 213756 [details]
patch

Clearing flags on attachment: 213756

Committed r157171: <http://trac.webkit.org/changeset/157171>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mario Sanchez Prada]

(In reply to comment #3)
> [...]
> Thanks for looking at this. On iOS, we don't have a notion of attribute names. 
> Properties are just exposed and queried for when desired

Ah! That explains why you don't have a attributeName() method in the IOS wrapper :)