Bug 122525 - Refined power management in SunSpider 1.0.2
Summary: Refined power management in SunSpider 1.0.2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-08 14:38 PDT by Geoffrey Garen
Modified: 2013-10-08 15:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.67 KB, patch)
2013-10-08 14:47 PDT, Geoffrey Garen
barraclough: review+
Details | Formatted Diff | Diff
Upload changes to webkit.org (26.64 KB, patch)
2013-10-08 14:54 PDT, Geoffrey Garen
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-10-08 14:38:50 PDT
Refined power management in SunSpider 1.0.2
Comment 1 Geoffrey Garen 2013-10-08 14:47:26 PDT
Created attachment 213721 [details]
Patch
Comment 2 Geoffrey Garen 2013-10-08 14:54:28 PDT
Created attachment 213722 [details]
Upload changes to webkit.org
Comment 3 Gavin Barraclough 2013-10-08 15:17:29 PDT
Comment on attachment 213721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213721&action=review

> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:60
> +function next() 

Bonus space!

> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:71
> +        for (var start = new Date; new Date - start < warmup; ) { }

This busy loop will churn through a lot of object creation – I wonder if it might be worth having a loop body containing math to spin up the CPU without also creating artificial GC pressure?
Comment 4 Geoffrey Garen 2013-10-08 15:38:41 PDT
Committed r157140: <http://trac.webkit.org/changeset/157140>
Comment 5 Geoffrey Garen 2013-10-08 15:38:53 PDT
Committed r157141: <http://trac.webkit.org/changeset/157141>