Bug 122517 - [MediaStream] Fix segfault in initializeMockSources()
Summary: [MediaStream] Fix segfault in initializeMockSources()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura Maranhao Neto
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-08 12:47 PDT by Lauro Moura Maranhao Neto
Modified: 2013-10-08 13:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2013-10-08 12:52 PDT, Lauro Moura Maranhao Neto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura Maranhao Neto 2013-10-08 12:47:33 PDT 
MockMediaStreamCenter.cpp initializeMockSources() tries to add a RefPtr<MockSource> to a HashMap by releasing it and also access a member function (id) in the same call. If the release() is evaluated before id(), a segfault occurs.
Comment 1 Lauro Moura Maranhao Neto 2013-10-08 12:52:42 PDT 
Created attachment 213709 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-08 13:29:10 PDT 
Comment on attachment 213709 [details]
Patch

Clearing flags on attachment: 213709

Committed r157132: <http://trac.webkit.org/changeset/157132>
Comment 3 WebKit Commit Bot 2013-10-08 13:29:12 PDT 
All reviewed patches have been landed.  Closing bug.