Bug 122515 - http://build.webkit.org/dashboard frequently shows stale or incorrect results
Summary: http://build.webkit.org/dashboard frequently shows stale or incorrect results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-08 12:24 PDT by Alexey Proskuryakov
Modified: 2013-10-09 14:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.29 KB, patch)
2013-10-09 13:33 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (5.29 KB, patch)
2013-10-09 13:51 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-08 12:24:17 PDT
Currently I'm seeing Lion Debug WK1 all green, but it's actually not.

Here is how an incorrect iteration looks in debugger:

> iteration
< Object
    _finished: true
    _listeners: Object
    apiTestResults: Object
    bindingTestResults: Object
    failed: true
    id: 11156
    internalRevision: null
    javascriptTestResults: Object
    layoutTestResults: Object
        allPassed: true
        errorOccurred: false
        failureCount: 0
        finished: true
        flakeyCount: 0
        missingCount: 0
        newPassesCount: 0
        tooManyFailures: false
        totalLeakCount: 0
        uniqueLeakCount: 0
    __proto__: Object
    loaded: true
    openSourceRevision: 157116
    perlTestResults: Object
    pythonTestResults: Object
    queue: Object
    __proto__: Object
Comment 1 Timothy Hatcher 2013-10-09 13:33:01 PDT
Created attachment 213806 [details]
Patch
Comment 2 Timothy Hatcher 2013-10-09 13:46:05 PDT
Comment on attachment 213806 [details]
Patch

This patch is wrong.
Comment 3 Timothy Hatcher 2013-10-09 13:51:26 PDT
Created attachment 213809 [details]
Patch
Comment 4 WebKit Commit Bot 2013-10-09 14:32:59 PDT
Comment on attachment 213809 [details]
Patch

Clearing flags on attachment: 213809

Committed r157185: <http://trac.webkit.org/changeset/157185>
Comment 5 WebKit Commit Bot 2013-10-09 14:33:00 PDT
All reviewed patches have been landed.  Closing bug.