Bug 122513 - [CSS Shapes] Floats should be positioned based on the margin box inside shape-inside
Summary: [CSS Shapes] Floats should be positioned based on the margin box inside shape...
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 121615
  Show dependency treegraph
 
Reported: 2013-10-08 11:54 PDT by Zoltan Horvath
Modified: 2014-03-27 09:25 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-10-08 11:54:06 PDT
Currently, the shape-inside floats implementation doesn't deal with floats with margins/borders. Floats should be positioned based on the border box. (See Bem's comment: https://bugs.webkit.org/show_bug.cgi?id=121616#c7)
Comment 1 Bem Jones-Bey 2013-10-08 12:52:34 PDT
(In reply to comment #0)
> Currently, the shape-inside floats implementation doesn't deal with floats with margins/borders. Floats should be positioned based on the border box. (See Bem's comment: https://bugs.webkit.org/show_bug.cgi?id=121616#c7)

You mean floats should be positioned based on the margin box. (which is the dimensions you get when you use the logicalHeight/Width, etc of FloatingObject)

I was confused by your change, since you changed it from using the FloatingObject height/width to using the RenderBox's height/width, and I wasn't sure why.