Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
Created attachment 213668 [details] Patch
Comment on attachment 213668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213668&action=review r=me, this is much nicer than the old code. Thought: Do you think it would be cool to have a function that yanks items matching a [lambda] predicate out of a collection and returns them in a Vector? > Source/WebKit2/ChangeLog:9 > + (WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when puttin objects Typo, putting. > Source/WebKit2/Shared/Plugins/NPRemoteObjectMap.cpp:200 > + for (auto it = m_registeredNPObjects.begin(), end = m_registeredNPObjects.end(); it != end; ++it) { You can use range-based for in WebKit2. > Source/WebKit2/Shared/Plugins/NPRemoteObjectMap.cpp:209 > + for (auto it = m_npObjectProxies.begin(), end = m_npObjectProxies.end(); it != end; ++it) { Same here.
(In reply to comment #2) > Thought: Do you think it would be cool to have a function that yanks items matching a [lambda] predicate out of a collection and returns them in a Vector? Probably. It would use the word “take” in its name.
Committed r157090: <http://trac.webkit.org/changeset/157090>
This caused crashes all over the place in plug-in tests. Darin, are you around to take a look?
Re-opened since this is blocked by bug 122504
Rolled out in <http://trac.webkit.org/changeset/157105>. Test results: <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r157090%20(12401)/results.html>. Unfortunately, there are no crash logs (might be that they are actually freezes incorrectly detected as crashes).
Were the crashes only on Mountain Lion, or were they on Lion too?
Crashing on Lion too. Actually, that bot has crash logs - http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r157104%20(11972)/plugins/netscape-plugin-map-data-to-src-crash-log.txt
Committed r157157: <http://trac.webkit.org/changeset/157157>
Looks like the crashes came back with the new commit =(
Re-opened since this is blocked by bug 122547
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r157161%20(11989)/plugins/embed-prefers-plugins-for-images-crash-log.txt
Really? I did lots of testing locally and saw no crashes. I guess I am testing this wrong. Anders, can you help?
Created attachment 213786 [details] Patch
Anders, any ideas on why this second version of the patch still caused all those crashes on the bots, but not on my Mavericks development machine?
Created attachment 229547 [details] Patch
Committed r167431: <http://trac.webkit.org/changeset/167431>