Use references in EventRetargeter::calculateEventPath and EventRetargeter::eventTargetRespectingTargetRules
Created attachment 213665 [details] Cleanup
Comment on attachment 213665 [details] Cleanup Attachment 213665 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3746045
Comment on attachment 213665 [details] Cleanup Attachment 213665 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3735038
Created attachment 213669 [details] Fixed EFL build
Comment on attachment 213669 [details] Fixed EFL build View in context: https://bugs.webkit.org/attachment.cgi?id=213669&action=review > Source/WebCore/dom/EventRetargeter.cpp:89 > + EventTarget* target = 0; > > - for (Node* node = nodeOrHostIfPseudoElement(targetNode); node; node = node->parentOrShadowHostNode()) { > - if (targetStack.isEmpty()) > - targetStack.append(eventTargetRespectingTargetRules(node)); > + for (Node* node = nodeOrHostIfPseudoElement(&targetNode); node; node = node->parentOrShadowHostNode()) { > + if (!target) > + target = &eventTargetRespectingTargetRules(*node); > + You could make target a reference too by moving the initialisation out of the loop. > Source/WebCore/dom/EventRetargeter.h:73 > +inline EventTarget& EventRetargeter::eventTargetRespectingTargetRules(Node& referenceNode) > { This could probably be moved out of line.
Comment on attachment 213669 [details] Fixed EFL build View in context: https://bugs.webkit.org/attachment.cgi?id=213669&action=review >> Source/WebCore/dom/EventRetargeter.cpp:89 >> + > > You could make target a reference too by moving the initialisation out of the loop. We can't. target is overridden in some iterations; namely when the last node was a non-SVG shadow root. >> Source/WebCore/dom/EventRetargeter.h:73 >> { > > This could probably be moved out of line. Let me do that in a separate patch.
Comment on attachment 213669 [details] Fixed EFL build Landing as is for now.
Comment on attachment 213669 [details] Fixed EFL build Clearing flags on attachment: 213669 Committed r157123: <http://trac.webkit.org/changeset/157123>
All reviewed patches have been landed. Closing bug.