Bug 122492 - [Mac] Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
Summary: [Mac] Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 73757
  Show dependency tree / graph
 
Reported: 2013-10-07 23:47 PDT by Darin Adler
Modified: 2013-10-08 00:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (24.36 KB, patch)
2013-10-07 23:53 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-10-07 23:47:02 PDT 
Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
Comment 1 Darin Adler 2013-10-07 23:53:42 PDT 
Created attachment 213663 [details]
Patch
Comment 2 Andreas Kling 2013-10-08 00:00:38 PDT 
Comment on attachment 213663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213663&action=review

r=me

> Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:254
> -        m_replies.set(requestID, reply);
> +        m_replies.add(requestID, std::move(reply));

Nice.
Comment 3 WebKit Commit Bot 2013-10-08 00:44:19 PDT 
Comment on attachment 213663 [details]
Patch

Clearing flags on attachment: 213663

Committed r157089: <http://trac.webkit.org/changeset/157089>
Comment 4 WebKit Commit Bot 2013-10-08 00:44:20 PDT 
All reviewed patches have been landed.  Closing bug.