Bug 122489 - [Media] Refactor supportsType() factory method to take a parameters object.
Summary: [Media] Refactor supportsType() factory method to take a parameters object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-07 22:11 PDT by Jer Noble
Modified: 2013-10-22 17:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (23.82 KB, patch)
2013-10-07 22:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (31.57 KB, patch)
2013-10-07 23:39 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (31.61 KB, patch)
2013-10-08 07:58 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-10-07 22:11:41 PDT 
[Media] Refactor supportsType() factory method to take a parameters object.
Comment 1 Jer Noble 2013-10-07 22:16:33 PDT 
Created attachment 213655 [details]
Patch
Comment 2 Jer Noble 2013-10-07 23:39:33 PDT 
Created attachment 213661 [details]
Patch
Comment 3 Build Bot 2013-10-08 00:12:34 PDT 
Comment on attachment 213661 [details]
Patch

Attachment 213661 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3708112
Comment 4 Build Bot 2013-10-08 00:23:12 PDT 
Comment on attachment 213661 [details]
Patch

Attachment 213661 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3715126
Comment 5 Jer Noble 2013-10-08 07:58:40 PDT 
Created attachment 213686 [details]
Patch
Comment 6 Eric Carlson 2013-10-21 22:57:06 PDT 
Comment on attachment 213686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213686&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:405
> +    parameters.isMediaSource = !!m_mediaSource;

We will want to use this for other features  (eg. MediaStream), so an enum would be better than a Boolean here.
Comment 7 WebKit Commit Bot 2013-10-22 17:12:58 PDT 
Comment on attachment 213686 [details]
Patch

Clearing flags on attachment: 213686

Committed r157834: <http://trac.webkit.org/changeset/157834>
Comment 8 WebKit Commit Bot 2013-10-22 17:13:01 PDT 
All reviewed patches have been landed.  Closing bug.