Bug 122483 - EventDispatchBehavior is unnecessary
Summary: EventDispatchBehavior is unnecessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Evangelism (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-07 20:53 PDT by Ryosuke Niwa
Modified: 2013-10-08 00:08 PDT (History)
7 users (show)

See Also:


Attachments
Cleanup (4.76 KB, patch)
2013-10-07 20:54 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (5.14 KB, patch)
2013-10-07 21:14 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-07 20:53:45 PDT
EventDispatchBehavior is unnecessary
Comment 1 Ryosuke Niwa 2013-10-07 20:54:43 PDT
Created attachment 213648 [details]
Cleanup
Comment 2 Andreas Kling 2013-10-07 21:05:44 PDT
Comment on attachment 213648 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=213648&action=review

r=me.

> Source/WebCore/dom/EventRetargeter.cpp:38
> +static inline bool shouldEventCrossShadowBoundary(Event* event, ShadowRoot* shadowRoot, EventTarget* target)

All three parameters should be references.

> Source/WebCore/dom/EventRetargeter.cpp:48
> +            if (element->isMediaElement() && shadowRoot && shadowRoot->hostElement() == element)

'shadowRoot' is already null-checked by the caller.

> Source/WebCore/dom/EventRetargeter.cpp:58
> +    bool tagetIsInShadowRoot = targetNode && targetNode->treeScope().rootNode() == shadowRoot;

Typo, taget -> target.
Comment 3 Ryosuke Niwa 2013-10-07 21:14:17 PDT
Created attachment 213650 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-10-07 21:42:46 PDT
Comment on attachment 213650 [details]
Patch for landing

Clearing flags on attachment: 213650

Committed r157085: <http://trac.webkit.org/changeset/157085>
Comment 5 WebKit Commit Bot 2013-10-07 21:42:48 PDT
All reviewed patches have been landed.  Closing bug.