Bug 122480 - Consolidate findString functions
Summary: Consolidate findString functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-07 19:31 PDT by Sam Weinig
Modified: 2013-10-08 16:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.47 KB, patch)
2013-10-07 19:32 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (10.47 KB, patch)
2013-10-07 23:29 PDT, Sam Weinig 		darin: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-10-07 19:31:16 PDT 
Consolidate findString functions
Comment 1 Sam Weinig 2013-10-07 19:32:17 PDT 
Created attachment 213639 [details]
Patch
Comment 2 Build Bot 2013-10-07 20:18:51 PDT 
Comment on attachment 213639 [details]
Patch

Attachment 213639 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3715070
Comment 3 EFL EWS Bot 2013-10-07 20:31:34 PDT 
Comment on attachment 213639 [details]
Patch

Attachment 213639 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3706080
Comment 4 kov's GTK+ EWS bot 2013-10-07 21:46:23 PDT 
Comment on attachment 213639 [details]
Patch

Attachment 213639 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3714105
Comment 5 Sam Weinig 2013-10-07 23:29:35 PDT 
Created attachment 213659 [details]
Patch
Comment 6 EFL EWS Bot 2013-10-07 23:35:24 PDT 
Comment on attachment 213659 [details]
Patch

Attachment 213659 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3738041
Comment 7 Darin Adler 2013-10-08 02:17:49 PDT 
Comment on attachment 213659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213659&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:501
> +    WebCore::FindOptions options = (caseSensitive ? 0 : WebCore::CaseInsensitive) | (forward ? 0 : WebCore::Backwards) | (shouldWrap ? WebCore::WrapAround : 0) | WebCore::StartInSelection;

It’s wrap, not shouldWrap, in this function.
Comment 8 Sam Weinig 2013-10-08 16:47:46 PDT 
Committed r157146: <http://trac.webkit.org/changeset/157146>