RESOLVED FIXED 122480
Consolidate findString functions 
https://bugs.webkit.org/show_bug.cgi?id=122480
Summary Consolidate findString functions
Sam Weinig
Reported 2013-10-07 19:31:16 PDT
Consolidate findString functions
Attachments
Patch (10.47 KB, patch)
2013-10-07 19:32 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.47 KB, patch)
2013-10-07 23:29 PDT, Sam Weinig 		darin: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-10-07 19:32:17 PDT
Created attachment 213639 [details] Patch
Build Bot
Comment 2 2013-10-07 20:18:51 PDT
Comment on attachment 213639 [details] Patch Attachment 213639 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3715070
EFL EWS Bot
Comment 3 2013-10-07 20:31:34 PDT
Comment on attachment 213639 [details] Patch Attachment 213639 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3706080
kov's GTK+ EWS bot
Comment 4 2013-10-07 21:46:23 PDT
Comment on attachment 213639 [details] Patch Attachment 213639 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/3714105
Sam Weinig
Comment 5 2013-10-07 23:29:35 PDT
Created attachment 213659 [details] Patch
EFL EWS Bot
Comment 6 2013-10-07 23:35:24 PDT
Comment on attachment 213659 [details] Patch Attachment 213659 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3738041
Darin Adler
Comment 7 2013-10-08 02:17:49 PDT
Comment on attachment 213659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213659&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:501 > + WebCore::FindOptions options = (caseSensitive ? 0 : WebCore::CaseInsensitive) | (forward ? 0 : WebCore::Backwards) | (shouldWrap ? WebCore::WrapAround : 0) | WebCore::StartInSelection; It’s wrap, not shouldWrap, in this function.
Sam Weinig
Comment 8 2013-10-08 16:47:46 PDT
Committed r157146: <http://trac.webkit.org/changeset/157146>
Note You need to log in before you can comment on or make changes to this bug.