Bug 122468 – Track controls show metadata and chapter tracks

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Brendan Long]

Track controls show metadata and chapter tracks

[Brendan Long]

Created attachment 213619 [details]
Only show captions, descriptions and subtitles in the track menu

It doesn't make any sense to show chapters and metadata in the track menu. This patch doesn't show them.

[Build Bot]

Comment on attachment 213619 [details]
Only show captions, descriptions and subtitles in the track menu

Attachment 213619 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3717019

New failing tests:
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html

[Build Bot]

Created attachment 213624 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Darin Adler]

Comment on attachment 213619 [details]
Only show captions, descriptions and subtitles in the track menu

View in context: https://bugs.webkit.org/attachment.cgi?id=213619&action=review

The test is failing on the bot; you will need to figure out why before landing.

> Source/WebCore/page/CaptionUserPreferences.cpp:183
> +        RefPtr<TextTrack> track = trackList->item(i);

It’s not necessary to churn the reference counts of these tracks by putting them in a RefPtr. A raw pointer is a better choice. The best choice is to just use "auto".

[Build Bot]

Comment on attachment 213619 [details]
Only show captions, descriptions and subtitles in the track menu

Attachment 213619 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3713030

New failing tests:
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html

[Build Bot]

Created attachment 213628 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Brendan Long]

The problem here is that all of the track menu tests are skipped on Mac. It looks like for some reason it can't find the caption button. I've had an ongoing problem where DumpRenderTree crashes on my Mac, so I'm having trouble tracking it down.

[Brendan Long]

Created attachment 213787 [details]
Skip on Mac, Windows and EFL

EFL uses the caption button instead of the track menu. The trackmenu tests all fail on Mac right now (it can't find the button for some reason?), and Windows too (no canplaythrough event?). When the other tests are fixed, this one should start working too, so I just grouped it with them in the TestExpectations.

[Brendan Long]

Created attachment 213790 [details]
Replace RefPtr<TextTrack> with TextTrack*

[WebKit Commit Bot]

Comment on attachment 213790 [details]
Replace RefPtr<TextTrack> with TextTrack*

Clearing flags on attachment: 213790

Committed r157290: <http://trac.webkit.org/changeset/157290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.