I'm proposing a patch that adds missing HAVE(ACCESSIBILITY) guards to ATK's related files so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
<rdar://problem/15164815>
Created attachment 213580 [details] Patch
Created attachment 213581 [details] Patch
Comment on attachment 213581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213581&action=review > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > +namespace WTR { Is there code like this already inside AccessibilityUIElement.cpp?
> (From update of attachment 213581 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=213581&action=review > > > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > > +namespace WTR { > > Is there code like this already inside AccessibilityUIElement.cpp? Yes there is, you mean it could be reused ?. Sounds good, I will check this.
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > > > +namespace WTR { > > > > Is there code like this already inside AccessibilityUIElement.cpp? > Yes there is, you mean it could be reused ?. > Sounds good, I will check this. It could be reused as well as I guess bits from AccessibilityUIController.cpp Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp can be changed to #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY) but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen.
(In reply to comment #6) > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > > > > +namespace WTR { > > > > > > Is there code like this already inside AccessibilityUIElement.cpp? > > Yes there is, you mean it could be reused ?. > > Sounds good, I will check this. > > It could be reused as well as I guess bits from AccessibilityUIController.cpp > Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp > can be changed to > #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY) > > but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen. I think we should re-use these. I don't want to have to maintain two long lists of unsupported functions when adding to DRT
Created attachment 216655 [details] patch
(In reply to comment #7) > (In reply to comment #6) > > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > > > > > +namespace WTR { > > > > > > > > Is there code like this already inside AccessibilityUIElement.cpp? > > > Yes there is, you mean it could be reused ?. > > > Sounds good, I will check this. > > > > It could be reused as well as I guess bits from AccessibilityUIController.cpp > > Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp > > can be changed to > > #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY) > > > > but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen. > > I think we should re-use these. I don't want to have to maintain two long lists of unsupported functions when adding to DRT Yes, you are right in terms of maintenance, this would not be a good idea to support it. Thanks for the suggestion. I already prepared a new patch.
Comment on attachment 216655 [details] patch Clearing flags on attachment: 216655 Committed r159181: <http://trac.webkit.org/changeset/159181>
All reviewed patches have been landed. Closing bug.