Bug 122440 - JavaScriptCore fails to build
Summary: JavaScriptCore fails to build
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-10-07 00:47 PDT by Rob Płóciennik
Modified: 2013-10-08 02:40 PDT (History)
4 users (show)

See Also:

Proposed patch (1.48 KB, patch)
2013-10-07 00:50 PDT, Rob Płóciennik
mark.lam: review-
mark.lam: commit-queue-
Details | Formatted Diff | Diff
Proposed patch (1.41 KB, patch)
2013-10-07 23:17 PDT, Rob Płóciennik
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Płóciennik 2013-10-07 00:47:29 PDT
Compilation fails in debug due to 'comparison of unsigned expression >= 0 is always true'.
Comment 1 Rob Płóciennik 2013-10-07 00:50:52 PDT
Created attachment 213570 [details]
Proposed patch
Comment 2 Mark Lam 2013-10-07 08:59:33 PDT
Comment on attachment 213570 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213570&action=review

> Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:186
> +    ASSERT(!callFrame->codeBlock());
> +    ASSERT(!callFrame->codeBlock());

These asserts are meaningless without the line and column checks.  But you are right that the line and column checks are not valid.  Please remove the 2 asserts completely.
Comment 3 Rob Płóciennik 2013-10-07 23:17:48 PDT
Created attachment 213657 [details]
Proposed patch

Hasty patch on my part... Updated accordingly.
Comment 4 Mark Lam 2013-10-07 23:27:15 PDT
Comment on attachment 213657 [details]
Proposed patch

LGTM, but I'll need a reviewer to r+ the patch.
Comment 5 WebKit Commit Bot 2013-10-08 02:40:06 PDT
Comment on attachment 213657 [details]
Proposed patch

Clearing flags on attachment: 213657

Committed r157093: <http://trac.webkit.org/changeset/157093>
Comment 6 WebKit Commit Bot 2013-10-08 02:40:08 PDT
All reviewed patches have been landed.  Closing bug.