Bug 122433 - Factor text paint style computation out from InlineTextBox
Summary: Factor text paint style computation out from InlineTextBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-06 18:03 PDT by Antti Koivisto
Modified: 2013-10-06 19:16 PDT (History)
12 users (show)

See Also:


Attachments
patch (33.37 KB, patch)
2013-10-06 18:06 PDT, Antti Koivisto
kling: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
for bots (33.43 KB, patch)
2013-10-06 18:40 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-06 18:03:26 PDT
for the future
Comment 1 Antti Koivisto 2013-10-06 18:06:08 PDT
Created attachment 213547 [details]
patch
Comment 2 Andreas Kling 2013-10-06 18:13:18 PDT
Comment on attachment 213547 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213547&action=review

> Source/WebCore/rendering/TextPaintStyle.cpp:38
> +TextPaintStyle::TextPaintStyle()

I would zero-initialize the stroke width here for good measure.

> Source/WebCore/rendering/TextPaintStyle.h:54
> +void updateGraphicsContext(GraphicsContext*, const TextPaintStyle&, StrokeColorType = UseNormalStrokeColor);

This should take a GraphicsContext&.
Comment 3 EFL EWS Bot 2013-10-06 18:25:24 PDT
Comment on attachment 213547 [details]
patch

Attachment 213547 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3513054
Comment 4 Build Bot 2013-10-06 18:33:31 PDT
Comment on attachment 213547 [details]
patch

Attachment 213547 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3368046
Comment 5 EFL EWS Bot 2013-10-06 18:38:43 PDT
Comment on attachment 213547 [details]
patch

Attachment 213547 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3519060
Comment 6 Antti Koivisto 2013-10-06 18:40:47 PDT
Created attachment 213549 [details]
for bots
Comment 7 Antti Koivisto 2013-10-06 19:16:06 PDT
https://trac.webkit.org/r157015