Bug 122432 - Improve HashMap::add comment and other similar comments
Summary: Improve HashMap::add comment and other similar comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-06 17:03 PDT by Darin Adler
Modified: 2019-05-03 19:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.29 KB, patch)
2013-10-06 17:03 PDT, Darin Adler 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-10-06 17:03:01 PDT 
Improve HashMap::add comment and other similar comments
Comment 1 Darin Adler 2013-10-06 17:03:31 PDT 
Created attachment 213542 [details]
Patch
Comment 2 Andreas Kling 2013-10-06 17:34:22 PDT 
Comment on attachment 213542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213542&action=review

r=me with some suggestions from a non-native speaker:

> Source/WTF/wtf/HashCountedSet.h:60
> +        // Increases the count if an equal value is already present.

Increases -> Increments

> Source/WTF/wtf/HashCountedSet.h:62
> +        // and an isNewEntry bool that indicates if it is a new or existing entry.

I'd say "indicates whether" rather than "indicates if"

> Source/WTF/wtf/HashCountedSet.h:65
> +        // Reduces the count of the value, and removes it if count goes down to zero.

Reduces -> Decrements
Comment 3 Darin Adler 2013-10-07 18:57:58 PDT 
Committed r157077: <http://trac.webkit.org/changeset/157077>