WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122429
Make Vector::insert work for move-only types
https://bugs.webkit.org/show_bug.cgi?id=122429
Summary
Make Vector::insert work for move-only types
Darin Adler
Reported
2013-10-06 16:16:45 PDT
Make Vector::insert work for move-only types
Attachments
Patch
(4.25 KB, patch)
2013-10-06 16:18 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2013-10-06 16:18:08 PDT
Created
attachment 213536
[details]
Patch
WebKit Commit Bot
Comment 2
2013-10-06 16:19:49 PDT
Attachment 213536
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/history/HistoryItem.cpp']" exit_code: 1 Source/WTF/wtf/Vector.h:647: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2013-10-06 18:59:51 PDT
Comment on
attachment 213536
[details]
Patch Patch looks good, but where's the API test?
Alexey Proskuryakov
Comment 4
2013-10-07 10:04:00 PDT
Is there a requirement to have unit tests for WTF? I don't remember any discussion that resulted in support for such.
Anders Carlsson
Comment 5
2013-10-07 10:11:39 PDT
(In reply to
comment #4
)
> Is there a requirement to have unit tests for WTF? I don't remember any discussion that resulted in support for such.
I’ve been adding unit tests as I’ve been implementing the move-only functionality of WTF data structures.
Darin Adler
Comment 6
2013-10-07 10:20:46 PDT
Comment on
attachment 213536
[details]
Patch OK, I’ll upload a new patch with unit tests when I have some time to work on this.
Anders Carlsson
Comment 7
2013-10-07 18:03:54 PDT
Comment on
attachment 213536
[details]
Patch Nah, let’s land this. It was blocking a change Samsung want to make to their WorkQueue implementation.
WebKit Commit Bot
Comment 8
2013-10-07 18:26:51 PDT
Comment on
attachment 213536
[details]
Patch Clearing flags on attachment: 213536 Committed
r157074
: <
http://trac.webkit.org/changeset/157074
>
WebKit Commit Bot
Comment 9
2013-10-07 18:26:53 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug