Bug 122426 – results.html doesn't support non-HTML reference tests or references with external resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tim Horton]

The layout test harness links to -expected and -expected-mismatch files in WebKitBuild/*/layout-test-results, not in LayoutTests/, so if they reference external files, they will be missing.

Also, it explicitly links to -expected.html and -expected-mismatch.html, meaning that the link is broken for SVG ref tests.

I have a patch.

[Tim Horton]

Created attachment 213528 [details]
patch

[Build Bot]

Comment on attachment 213528 [details]
patch

Attachment 213528 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3484085

New failing tests:
fast/harness/results.html

[Build Bot]

Created attachment 213531 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213528 [details]
patch

Attachment 213528 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3487090

New failing tests:
fast/harness/results.html

[Build Bot]

Created attachment 213533 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Tim Horton]

Created attachment 213539 [details]
patch

[Tim Horton]

http://trac.webkit.org/changeset/157020

[Alexey Proskuryakov]

So what does this fix, just local results? Are results on buildbot still broken in the same way as before?

[Tim Horton]

(In reply to comment #8)
> So what does this fix, just local results? Are results on buildbot still broken in the same way as before?

AFAIK results.html is used for the results saved from the bots as well; references will now (when needed) point to trac instead of the result directory, so they should be able to load external resources now.

[Tim Horton]

(In reply to comment #9)
> (In reply to comment #8)
> > So what does this fix, just local results? Are results on buildbot still broken in the same way as before?
> 
> AFAIK results.html is used for the results saved from the bots as well; references will now (when needed) point to trac instead of the result directory, so they should be able to load external resources now.

Note that I have not tested this, but I will when the bots cycle.