WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122421
Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=122421
Summary
Clean up ContentData
Anders Carlsson
Reported
2013-10-06 12:52:04 PDT
Clean up ContentData
Attachments
Patch
(14.25 KB, patch)
2013-10-06 12:54 PDT
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-10-06 12:54:25 PDT
Created
attachment 213521
[details]
Patch
Andreas Kling
Comment 2
2013-10-06 12:59:16 PDT
Comment on
attachment 213521
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=213521&action=review
> Source/WebCore/rendering/style/ContentData.h:50 > + virtual std::unique_ptr<ContentData> clone() const;
override
> Source/WebCore/rendering/style/ContentData.h:65 > + ImageContentData(PassRefPtr<StyleImage> image)
explicit
> Source/WebCore/rendering/style/ContentData.h:97 > + TextContentData(const String& text)
explicit
> Source/WebCore/rendering/style/ContentData.h:123 > + CounterContentData(std::unique_ptr<CounterContent> counter)
explicit
> Source/WebCore/rendering/style/ContentData.h:153 > + QuoteContentData(QuoteType quote)
explicit
Anders Carlsson
Comment 3
2013-10-06 13:13:11 PDT
Committed
r157005
: <
http://trac.webkit.org/changeset/157005
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug