Bug 122414 - context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
Summary: context-menu-suggestions-multiword-selection.html and context-menu-suggestion...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on:
Blocks: 108370 113742
  Show dependency treegraph
 
Reported: 2013-10-06 10:22 PDT by Alexey Proskuryakov
Modified: 2013-10-08 02:56 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.88 KB, patch)
2013-10-07 07:18 PDT, Grzegorz Czajkowski
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-06 10:22:48 PDT
The following layout test is very flaky on Mac.

editing/spelling/context-menu-suggestions-multiword-selection.html

This started with <http://trac.webkit.org/changeset/156901>.

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fspelling%2Fcontext-menu-suggestions-multiword-selection.html
Comment 1 Alexey Proskuryakov 2013-10-06 10:28:15 PDT
Marked as flaky in r156990.
Comment 2 Grzegorz Czajkowski 2013-10-07 04:36:32 PDT
Committed r157034: <http://trac.webkit.org/changeset/157034>
Comment 3 Grzegorz Czajkowski 2013-10-07 04:49:24 PDT
Marked as flaky context-menu-suggestions-subword-selection.html too. It started failing for Mac similarly to context-menu-suggestions-multiword-selection.html.
Comment 4 Grzegorz Czajkowski 2013-10-07 07:18:52 PDT
Created attachment 213579 [details]
Patch
Comment 5 Ryosuke Niwa 2013-10-07 11:02:43 PDT
Comment on attachment 213579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review

> LayoutTests/editing/spelling/resources/util.js:28
> +    }, true /* Doesn't produce logs on success. */ );

I think it's fine to output this. We just need to rebaseline the tests.
Comment 6 Grzegorz Czajkowski 2013-10-07 11:54:16 PDT
(In reply to comment #5)
> (From update of attachment 213579 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review
> 
> > LayoutTests/editing/spelling/resources/util.js:28
> > +    }, true /* Doesn't produce logs on success. */ );
> 
> I think it's fine to output this. We just need to rebaseline the tests.

Sure, will do that before landing. We should be aware that more spellchecking tests include utils.js and those need to be rebaselined too.
Comment 7 Grzegorz Czajkowski 2013-10-08 02:56:53 PDT
Committed r157094: <http://trac.webkit.org/changeset/157094>